test: Add dependency injection for remote function thrift client #16231
+190
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Feb 4, 2026
…ebookincubator#16231) Summary: Refactored the remote function client to use dependency injection, enabling proper mocking in tests: 1. Added `IRemoteFunctionClient` abstract interface in ThriftClient.h with `invokeFunction()` method 2. Added `ThriftRemoteFunctionClient` default implementation that wraps the actual thrift client 3. Added `RemoteFunctionClientFactory` type alias for creating clients 4. Added optional `clientFactory` field to `RemoteThriftVectorFunctionMetadata` 5. Modified `RemoteThriftFunction` to use injected factory (with fallback to default) 6. Added `MockRemoteFunctionTest` test fixture demonstrating mock client usage 7. Added 3 new tests using mock clients instead of real thrift server This allows tests to inject mock clients instead of requiring a real thrift server, making tests faster and more isolated. Differential Revision: D92213049
…ebookincubator#16231) Summary: Refactored the remote function client to use dependency injection, enabling proper mocking in tests: 1. Added `IRemoteFunctionClient` abstract interface in ThriftClient.h with `invokeFunction()` method 2. Added `ThriftRemoteFunctionClient` default implementation that wraps the actual thrift client 3. Added `RemoteFunctionClientFactory` type alias for creating clients 4. Added optional `clientFactory` field to `RemoteThriftVectorFunctionMetadata` 5. Modified `RemoteThriftFunction` to use injected factory (with fallback to default) 6. Added `MockRemoteFunctionTest` test fixture demonstrating mock client usage 7. Added 3 new tests using mock clients instead of real thrift server This allows tests to inject mock clients instead of requiring a real thrift server, making tests faster and more isolated. Differential Revision: D92213049
kunigami
force-pushed
the
export-D92213049
branch
from
6d91409 to
1775307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactored the remote function client to use dependency injection, enabling proper mocking in tests:
IRemoteFunctionClientabstract interface in ThriftClient.h withinvokeFunction()methodThriftRemoteFunctionClientdefault implementation that wraps the actual thrift clientRemoteFunctionClientFactorytype alias for creating clientsclientFactoryfield toRemoteThriftVectorFunctionMetadataRemoteThriftFunctionto use injected factory (with fallback to default)MockRemoteFunctionTesttest fixture demonstrating mock client usageThis allows tests to inject mock clients instead of requiring a real thrift server, making tests faster and more isolated.
Differential Revision: D92213049