feat: Add isDefaultNullBehavior API#16239
Closed
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat: Add isDefaultNullBehavior API#16239mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92271292. |
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Feb 4, 2026
Summary: Add `isDefaultNullBehavior` function to the Velox function registry API. This function allows callers to check if a registered function has default null behavior (null in any input produces null output). This API is needed by the Axiom optimizer to determine whether filter predicates can be pushed through outer joins. Differential Revision: D92271292
mbasmanova
force-pushed
the
export-D92271292
branch
from
0bab9da to
cd4e3e6
Compare
Summary: Add `isDefaultNullBehavior` function to the Velox function registry API. This function allows callers to check if a registered function has default null behavior (null in any input produces null output). This API is needed by the Axiom optimizer to determine whether filter predicates can be pushed through outer joins. Differential Revision: D92271292
mbasmanova
force-pushed
the
export-D92271292
branch
from
cd4e3e6 to
b334fa3
Compare
srsuryadev
approved these changes
Feb 4, 2026
srsuryadev
approved these changes
Feb 4, 2026
|
|
||
| std::optional<bool> isDefaultNullBehavior(const std::string& functionName) { | ||
| const auto simpleFunctions = | ||
| exec::simpleFunctions().getFunctionSignaturesAndMetadata(functionName); |
Contributor
There was a problem hiding this comment.
Let's address minor nits
|
This pull request has been merged in a6fa501. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
isDefaultNullBehaviorfunction to the Velox function registry API. This function allows callers to check if a registered function has default null behavior (null in any input produces null output).This API is needed by the Axiom optimizer to determine whether filter predicates can be pushed through outer joins.
Differential Revision: D92271292