Adding Media wiki mini #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77192531 |
marziehlenjaniMeta
added a commit
to marziehlenjaniMeta/DCPerf
that referenced
this pull request
Jun 24, 2025
Summary: This diff adds a config for media_wiki mini job. I am changing the oss_performance code that will add more options for reducing execution time that needs to be added to the mini job config. So, those options will be added to the config Also, we need to add --temp-dir to the mini config, but Ideally, we want to add the --temp-dir, only if the user provide a value for that. So, we need to decide on how to do it. Reviewed By: excelle08 Differential Revision: D77192531
marziehlenjaniMeta
force-pushed
the
export-D77192531-to-v2-beta
branch
from
029cf81 to
411366c
Compare
Summary: Pull Request resolved: facebookresearch#145 This diff adds a config for media_wiki mini job. I am changing the oss_performance code that will add more options for reducing execution time that needs to be added to the mini job config. So, those options will be added to the config Also, we need to add --temp-dir to the mini config, but Ideally, we want to add the --temp-dir, only if the user provide a value for that. So, we need to decide on how to do it. Reviewed By: excelle08 Differential Revision: D77192531
|
This pull request was exported from Phabricator. Differential Revision: D77192531 |
marziehlenjaniMeta
force-pushed
the
export-D77192531-to-v2-beta
branch
from
411366c to
1fbf056
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
Summary: Pull Request resolved: #145 This diff adds a config for media_wiki mini job. I am changing the oss_performance code that will add more options for reducing execution time that needs to be added to the mini job config. So, those options will be added to the config Also, we need to add --temp-dir to the mini config, but Ideally, we want to add the --temp-dir, only if the user provide a value for that. So, we need to decide on how to do it. Reviewed By: excelle08 Differential Revision: D77192531 fbshipit-source-id: 45af99d8ab579106c8fe56672554a51e2785f29d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a config for media_wiki mini job. I am changing the oss_performance code that will add more options for reducing execution time that needs to be added to the mini job config. So, those options will be added to the config
Also, we need to add --temp-dir to the mini config, but Ideally, we want to add the --temp-dir, only if the user provide a value for that. So, we need to decide on how to do it.
Differential Revision: D77192531