Repository navigation
231 apply customized parser config for individual traces - #232
Closed
fengxizhou wants to merge 1 commit into
Closed
fengxizhou wants to merge 1 commit into
fengxizhou wants to merge 1 commit into
Conversation
Contributor
|
@fengxizhou has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
HugeEngine
approved these changes
Mar 10, 2025
Summary:
## What does this PR do?
Currently, HTA applies a global parser configuration to all input traces. This approach poses challenges when an application that requires different parser configurations.
**Proposed API Changes:**
class Trace:
def __init__(
self,
trace_files: Optional[Union[List[str], Dict[int, str]]] = None,
trace_dir: str = DEFAULT_TRACE_DIR,
parser_config: Optional[ParserConfig] = None,
) -> None:
## Before submitting
- [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
- [ ] N/A
- [x] Did you write any new necessary tests?
- [ ] N/A
- [x] Did you make sure to update the docs?
- [] N/A
- [x] Did you update the [changelog](https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/CHANGELOG.md)?
- [ ] N/A
Reviewed By: HugeEngine
Differential Revision: D70897915
Pulled By: fengxizhou
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70897915 |
facebook-github-bot
force-pushed
the
231-apply-customized-parser-config-for-individual-traces
branch
from
March 11, 2025 15:27
3c56ee2 to
c7140a2
Compare
Contributor
|
@fengxizhou merged this pull request in 9275384. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, HTA applies a global parser configuration to all input traces. This approach poses challenges when an application that requires different parser configurations.
Proposed API Changes:
class Trace:
def init(
self,
trace_files: Optional[Union[List[str], Dict[int, str]]] = None,
trace_dir: str = DEFAULT_TRACE_DIR,
parser_config: Optional[ParserConfig] = None,
) -> None:
Before submitting