Skip to content

231 apply customized parser config for individual traces - #232

Closed
fengxizhou wants to merge 1 commit into
mainfrom
231-apply-customized-parser-config-for-individual-traces
Closed

fengxizhou wants to merge 1 commit into
mainfrom
231-apply-customized-parser-config-for-individual-traces

Conversation

@fengxizhou

Copy link
Copy Markdown
Contributor

What does this PR do?

Currently, HTA applies a global parser configuration to all input traces. This approach poses challenges when an application that requires different parser configurations.

Proposed API Changes:
class Trace:
def init(
self,
trace_files: Optional[Union[List[str], Dict[int, str]]] = None,
trace_dir: str = DEFAULT_TRACE_DIR,
parser_config: Optional[ParserConfig] = None,
) -> None:

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you make sure to update the docs?
    • [] N/A
  • Did you update the changelog?
    • N/A

@fengxizhou fengxizhou linked an issue Mar 9, 2025 that may be closed by this pull request
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2025
@fengxizhou fengxizhou self-assigned this Mar 9, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@fengxizhou has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
## What does this PR do?

Currently, HTA applies a global parser configuration to all input traces. This approach poses challenges when an application that requires different parser configurations.

**Proposed API Changes:**
class Trace:
    def __init__(
        self,
        trace_files: Optional[Union[List[str], Dict[int, str]]] = None,
        trace_dir: str = DEFAULT_TRACE_DIR,
        parser_config: Optional[ParserConfig] = None,
    ) -> None:

## Before submitting

- [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  - [ ] N/A
- [x] Did you write any new necessary tests?
  - [ ] N/A
- [x] Did you make sure to update the docs?
  - [] N/A
- [x] Did you update the [changelog](https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/CHANGELOG.md)?
  - [ ] N/A


Reviewed By: HugeEngine

Differential Revision: D70897915

Pulled By: fengxizhou
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D70897915

@facebook-github-bot
facebook-github-bot force-pushed the 231-apply-customized-parser-config-for-individual-traces branch from 3c56ee2 to c7140a2 Compare March 11, 2025 15:27
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@fengxizhou merged this pull request in 9275384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply Customized Parser Config for Individual Traces

3 participants