This repository was archived by the owner on Aug 6, 2025. It is now read-only.
Option to install MeCab automatically (also on Docker) and fix MeCab encoding issues#97
Closed
yannvgn wants to merge 3 commits intofacebookresearch:masterfrom
Closed
Option to install MeCab automatically (also on Docker) and fix MeCab encoding issues#97yannvgn wants to merge 3 commits intofacebookresearch:masterfrom
yannvgn wants to merge 3 commits intofacebookresearch:masterfrom
Conversation
fix mecab installation test install mecab on dockerized laser
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Author
|
I'm closing this as MeCab is not needed anymore with LASER2 (#153 (comment)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @hoschwenk
I'm the maintainer of laserembeddings, a packaged version of LASER installable with
pip.During the generation of samples of sentence embeddings (used to make sure the results I get with my package are the same as computed here) I had troubles processing Japanese sentences.
I followed the installation instructions of MeCab but I had weird issues that seemed to be related to the encoding used by MeCab.
I also noticed that MeCab was not installed by default in the Docker version of LASER (there's no reason not to install it there by default I think).
This PR in a nutshell:
--install-mecaboption toinstall_external_tools.sh(disabled by default) to try the automatic installation of MeCab (which should work in many contexts)install_external_tools.shagain)This would hopefully solve #54 and #92
Last but not least: THANK YOU for releasing and open-sourcing LASER. It is SO helpful for us who have to work on multilingual contexts. ✨✨✨