Repository navigation
Conversation
Removing either guard from the generated javascripts/mathjax.js passed every test (#415). One test loads MathJax before the script, as a mkdocs.yml that lists the bundle first does, and requires the guard's error and no formula typeset, against a control run without the script that typesets both. The other has the harness's MathJax report another release and requires the version error and no pass.
… labels From #455's final pass, each with a test that fails without it: - The page input no longer processes a reference outside a formula, so a bare \ref in an explorer summary shows as typed rather than as ???; every article formula is delimited. - A pass that adds to the page skips MathJax's output, so the hidden copy each formula keeps for assistive technology is not read again: a title whose \text held two \$ got a second, invisible formula there. - The site's rule that clips a block holding a formula leaves the explorer alone. Its panels scroll, and the rule clipped the sides of the focus rings of rail and relation rows holding a formula. - A distribution label is flex, so its text goes in a span of its own and a typeset "$K$-theory" stays one item. The Node harness records the options the script asks of each document, so the menu-free document for formulas in controls is checked there too, and the tests pin that search rows, the head's trail and the handle with nothing selected show titles as typed.
Contributor
Author
|
Review of #468 at 267445c: fix before merge. The four fixes work and each is pinned by a test. But the clip-rule change turns CI red. Blocks merge
Note
Checked and fine
Posted by jackmccarthy-77. |
The site stylesheet names nothing of the explorer's, as test_the_site_stylesheet_leaves_the_explorer_to_its_own_rules checks, so the site's rule that clips a block holding a formula is back as it was, and the explorer's style lets its lists overflow sideways instead: its panels scroll, and the clip cut the sides of its rows' focus rings. The summary keeps its clipping, which its four-line clamp needs. The changelog line moves under Fixed. Reviewed by jackmccarthy-77.
The cards' steps had no skipHtmlTags, so a pass that added to a page read
each card's typeset formulas again, and a card formula whose text held TeX,
such as \text{see \begin{cases}a\end{cases}}, got a hidden formula typeset in
its assistive copy: the changelog line said no pass did that. The card steps
now share the page steps' skip. The Node test's explorer pass carries such a
card formula and checks that neither card finds anything.
Contributor
Author
|
Closed in favour of #471, at Jack's request: the fixes are tracked there and can land with, or after, the explorer rewrite in #442 and #444. The branch fix/explorer-math-followups (head 9e4a8c8) keeps the tested fixes and the merge-order session's MathJax guard tests, and jackmccarthy-77's review blocker is fixed on it. |
Contributor
Author
|
Second round on #468 at 9e4a8c8: the blocker is fixed, and nothing blocks merge.
Posted by jackmccarthy-77. |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
\refstays as typed. The page input now setsprocessRefs: false. With it on, a\ref{x}or\eqref{y}in an explorer summary, outside any formula, was typeset as???and(???). Every article formula is delimited, so articles are unaffected.\textheld two\$got a second, invisible formula there, with a tab stop and garbled speech, and so did a card formula whose text held TeX, such as\text{see \begin{cases}a\end{cases}}. The page and card steps now addmjx-containertoskipHtmlTags.:has(mjx-container) { overflow-x: clip }) matched the rail and relation lists once a row held a formula, which clipped the sides of the rows' focus rings. The explorer's own style now lets its lists overflow sideways, inside panels that scroll; the site stylesheet stays free of explorer rules, and the summary keeps the clipping its four-line clamp needs.$K$-theorysplit into flex items and showed asK -theory. Its text now goes in a span of its own.Tests
tests/test_site_mathjax_node.py:enableMenu: false, the explorer's render action off) andskipHtmlTagson both page documents.\refand, on the first page, an article formula whose assistive copy holds a pair of dollar signs and a card formula whose copy holds an environment. The explorer's pass typesets neither the reference nor anything in the copies. DroppingprocessRefs: falseor eitherskipHtmlTagsentry fails it.test_another_mathjax_release_leaves_every_formula_as_typedandtest_a_mathjax_listed_before_the_script_typesets_nothing. Removing either guard frommathjax.pyfails its test.tests/test_graph_view_rendering.pypins the explorer's list rule, the label's span, the handle's class toggle, and that search rows and the head's trail stay unmarked.tests/test_dag_viewer_browser.pychecks, with the real MathJax, that the head's trail shows its TeX label as typed.Overlap
#442 and #444 rewrite the explorer and already conflict with main in
autoform_cli/mathjax.py,autoform_cli/dag_viewer.py,tests/test_site_mathjax_node.pyandtests/test_dag_viewer_browser.py, because of #455. This adds small hunks to the same files. Whichever lands second carries these fixes into the other's code.Validation
jackmccarthy-77's review at
267445c1(comment) found the site stylesheet naming the explorer, whichtest_render.pyforbids;28a48c80moves that rule into the explorer's own style and the changelog line under Fixed. An adversarial review of267445c1found the same blocker, plus the card steps still rereading typeset output, which the changelog line claimed no pass did;9e4a8c8agives the card steps the same skip. Locally the render, site-math, rendering, Node MathJax, release and doc-budget suites pass. CI is running on9e4a8c8a.