Update type hint for name_or_path to support Path#1836
Open
Andrew-S-Rosen wants to merge 5 commits into
Open
Conversation
Contributor
|
Thanks @Andrew-S-Rosen - can you just install the pre-commit hooks we have and run that so linting can get taken care of |
Contributor
Author
|
@mshuaibii --- yup! I had naively assumed pre-commit CI was running here. Should be fixed now. |
lbluque
approved these changes
Mar 13, 2026
|
This PR has been marked as stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type hint for
name_or_pathhas been updated fromstrtostr | Path