This repository was archived by the owner on Mar 20, 2026. It is now read-only.
Refactor hub interface for batched inference#1539
Closed
sai-prasanna wants to merge 3 commits into
Closed
Conversation
myleott
reviewed
Dec 23, 2019
myleott
left a comment
myleott
left a comment
There was a problem hiding this comment.
Thanks!
One concern is that this will break the API for non-batched inputs. We have a few tutorials around that rely on this, so we should add some backward compatibility. I'll take care of this before merging.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@myleott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@myleott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 26, 2019
Summary: # Before submitting - [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [x] Did you read the [contributor guideline](https://github.com/pytorch/fairseq/blob/master/CONTRIBUTING.md)? - [x] Did you make sure to update the docs? - [] Did you write any new necessary tests? ## What does this PR do? Fixes #1508. Pull Request resolved: #1539 Pulled By: myleott Differential Revision: D19216104 fbshipit-source-id: 14917c1459b8794eeb74c09a16b9899c366242d2
moussaKam
pushed a commit
to moussaKam/language-adaptive-pretraining
that referenced
this pull request
Sep 29, 2020
…acebookresearch#1539) Summary: # Before submitting - [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [x] Did you read the [contributor guideline](https://github.com/pytorch/fairseq/blob/master/CONTRIBUTING.md)? - [x] Did you make sure to update the docs? - [] Did you write any new necessary tests? ## What does this PR do? Fixes facebookresearch#1508. Pull Request resolved: facebookresearch#1539 Pulled By: myleott Differential Revision: D19216104 fbshipit-source-id: 14917c1459b8794eeb74c09a16b9899c366242d2
yzpang
pushed a commit
to yzpang/gold-off-policy-text-gen-iclr21
that referenced
this pull request
Feb 19, 2021
Summary: # Before submitting - [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [x] Did you read the [contributor guideline](https://github.com/pytorch/fairseq/blob/master/CONTRIBUTING.md)? - [x] Did you make sure to update the docs? - [] Did you write any new necessary tests? ## What does this PR do? Fixes facebookresearch/fairseq#1508. Pull Request resolved: facebookresearch/fairseq#1539 Pulled By: myleott Differential Revision: D19216104 fbshipit-source-id: 14917c1459b8794eeb74c09a16b9899c366242d2
yzpang
pushed a commit
to yzpang/gold-off-policy-text-gen-iclr21
that referenced
this pull request
Feb 19, 2021
Summary: # Before submitting - [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [x] Did you read the [contributor guideline](https://github.com/pytorch/fairseq/blob/master/CONTRIBUTING.md)? - [x] Did you make sure to update the docs? - [] Did you write any new necessary tests? ## What does this PR do? Fixes facebookresearch/fairseq#1508. Pull Request resolved: facebookresearch/fairseq#1539 Pulled By: myleott Differential Revision: D19216104 fbshipit-source-id: 14917c1459b8794eeb74c09a16b9899c366242d2
Harleen8118
pushed a commit
to Harleen8118/IBERT
that referenced
this pull request
Jun 26, 2025
Summary: # Before submitting - [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [x] Did you read the [contributor guideline](https://github.com/pytorch/fairseq/blob/master/CONTRIBUTING.md)? - [x] Did you make sure to update the docs? - [] Did you write any new necessary tests? ## What does this PR do? Fixes facebookresearch/fairseq#1508. Pull Request resolved: facebookresearch/fairseq#1539 Pulled By: myleott Differential Revision: D19216104 fbshipit-source-id: 14917c1459b8794eeb74c09a16b9899c366242d2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1508.