Skip to content

[sensor] Change sensor enum from ALL_CAPS to Pascal style#1009

Merged
vauduong merged 2 commits into
facebookresearch:masterfrom
vauduong:copy3-enum-pascal
Jan 6, 2021
Merged

[sensor] Change sensor enum from ALL_CAPS to Pascal style#1009
vauduong merged 2 commits into
facebookresearch:masterfrom
vauduong:copy3-enum-pascal

Conversation

@vauduong

@vauduong vauduong commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

Motivation and Context

Changing the style of the enumeration in Sensor.h

How Has This Been Tested

Built and compiled

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 6, 2021
@Skylion007

Copy link
Copy Markdown
Contributor

@vauduong Try pulling from master and see if that solves the CircleCI issue.

@bigbike bigbike left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your 1st PR!

@bigbike bigbike marked this pull request as ready for review January 6, 2021 23:04
@vauduong vauduong merged commit 37a29d3 into facebookresearch:master Jan 6, 2021
@vauduong vauduong deleted the copy3-enum-pascal branch January 6, 2021 23:18
@bigbike bigbike changed the title Change sensor enum from ALL_CAPS to Pascal style [sensor] Change sensor enum from ALL_CAPS to Pascal style Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants