Skip to content

add ESP_CHECK and one example usage#1111

Merged
eundersander merged 1 commit intofacebookresearch:masterfrom
eundersander:eundersander/esp_check
Mar 1, 2021
Merged

add ESP_CHECK and one example usage#1111
eundersander merged 1 commit intofacebookresearch:masterfrom
eundersander:eundersander/esp_check

Conversation

@eundersander
Copy link
Copy Markdown
Contributor

@eundersander eundersander commented Feb 27, 2021

Motivation and Context

Add ESP_CHECK macro, for use with fatal runtime errors. The Check.h header also gives guidelines on error-handling in Habitat-sim.

Thanks @mosra for providing most of the implementation here.

See this internal doc for more discussion.

I added one example usage of ESP_CHECK in LightSetup.cpp.

How Has This Been Tested

Ad hoc testing from a Python unit test (causing an AssertionError exception) and a C++ unit test (causing an abort).

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 27, 2021
@eundersander eundersander merged commit 19457d4 into facebookresearch:master Mar 1, 2021
@eundersander eundersander deleted the eundersander/esp_check branch March 1, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants