Add tinyxml2 to dependencies

[aclegg3]

Motivation and Context

Used to parse URDF files for upcoming articulated object support. Also useful for parsing/writing other xml, for example: SVX format for loading/saving voxel fields or SDF for representing scenes.

Copied from articulated-objects-prototype branch.

How Has This Been Tested

It builds.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have completed my CLA (see CONTRIBUTING)
• I have added tests to cover my changes.
• All new and existing tests passed.

[Skylion007]

@aclegg3 Any reason it's not loaded in as a submodule?

[aclegg3]

@aclegg3 Any reason it's not loaded in as a submodule?

Primarily just that the git repo is 6+ MB with 253 files (mostly docs and configurations for various build systems) when all we need is ~130KB of these 3 files. 🤷

[Skylion007]

True, although it does make version control a bit more painful.

…

On Thu, Mar 18, 2021 at 7:45 PM Alexander Clegg ***@***.***> wrote: @aclegg3 <https://github.com/aclegg3> Any reason it's not loaded in as a submodule? Primarily just that the git repo is 6+ MB with 253 files (mostly docs and configurations for various build systems) when all we need is ~130KB of these 3 files. 🤷 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1137 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPVMX4JNYHF4EACL7DOFX3TEKGB7ANCNFSM4Y4D5TXA> .

[jturner65]

LGTM

[mosra]

Missed this, it's causing a lot of -Wzero-as-null-pointer-constant warnings. I think we shouldn't enable pedantic flags for 3rd party dependencies, as we can't really control what's there. Opened #1233 to remove it.