[Sensor] VisualSensor and CameraSensor updates for Hierarchical SensorSpec#1138
Merged
vauduong merged 2 commits intofacebookresearch:masterfrom Mar 12, 2021
Merged
[Sensor] VisualSensor and CameraSensor updates for Hierarchical SensorSpec#1138vauduong merged 2 commits intofacebookresearch:masterfrom
vauduong merged 2 commits intofacebookresearch:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
vauduong
requested review from
Skylion007,
aclegg3,
bigbike,
erikwijmans,
eundersander and
jturner65
vauduong
changed the title
Contributor
Author
|
Thanks @eundersander for the feedback and the catch! The PR has been updated now. |
Contributor
|
@vauduong : I have not seen anyone approved this PR before you merged it in. |
Contributor
Author
Oh no! Sorry I think I saw a lot of green and thought it was approved. Do you have any more suggestions? If so I can create another PR. Thank you for letting me know and sorry for being too hasty. |
bigbike
reviewed
Mar 12, 2021
Contributor
bigbike
left a comment
bigbike
left a comment
There was a problem hiding this comment.
You do not have to roll back this one. But please be more careful next time.
For the small comments I made in this PR, you can fix them in the ongoing pr (sensorSuite).
| bool gpu2gpuTransfer = false; // True for pytorch tensor support | ||
| vec2i resolution = {128, 128}; // height x width | ||
| int channels = | ||
| 4; // Number of components in buffer values, eg. 4 channels for RGBA |
Contributor
There was a problem hiding this comment.
Can you change the comment style to
/**
* @brief ...
*/
| */ | ||
| bool displayObservation(sim::Simulator& sim) override; | ||
|
|
||
| bool isVisualSensor() const override { return true; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR introduces changes to VisualSensor, CameraSensor, VisualSensorSpec, and CameraSensorSpec in order for
the hierarchical SensorSpec to be correct when new Sensors are introduced.
In this PR:
See https://github.com/facebookresearch/habitat-sim/pull/1090/files#r588849042 for context
How Has This Been Tested
Build and run tests
Types of changes
Checklist