WebXR Controls Improvements v2#1139
Merged
eundersander merged 4 commits intofacebookresearch:masterfrom Mar 15, 2021
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
eundersander
commented
Mar 13, 2021
| node.setRotation(Magnum::Quaternion(quatf(rot)).normalized()); | ||
| } | ||
|
|
||
| vec3f quaternionToEuler(const quatf& q) { |
Contributor
Author
There was a problem hiding this comment.
I don't see anything using these so I'm removing them.
11 tasks
eundersander
commented
Mar 13, 2021
| .function("normalized", &Magnum::Quaternion::normalized) | ||
| .function("inverted", &Magnum::Quaternion::inverted) | ||
| .function("transformVector", &Magnum::Quaternion::transformVector) | ||
| .class_function("mul", &Quaternion_mul) |
Contributor
Author
There was a problem hiding this comment.
mul class method instead of of operator*
eundersander
commented
Mar 13, 2021
|
|
||
| if (initializeTopDown) { | ||
| let topdownElement = document.getElementById("topdown"); | ||
| if (initializeTopDown && topdownElement) { |
Contributor
Author
There was a problem hiding this comment.
make WebDemo robust to a missing topdown canvas
Skylion007
approved these changes
Mar 13, 2021
| echo "http://0.0.0.0:8000/build_js/utils/viewer/viewer.html?scene=skokloster-castle.glb" | ||
| echo "Or:" | ||
| echo "http://0.0.0.0:8000/build_js/esp/bindings_js/bindings.html?scene=skokloster-castle.glb" | ||
| echo "http://0.0.0.0:8000/build_js/esp/bindings_js/webvr.html?scene=skokloster-castle.glb" |
Contributor
There was a problem hiding this comment.
There should be a note here that this one requires a VR device.
eundersander
force-pushed
the
eundersander/webxr2
branch
from
f4164b7 to
224836d
Compare
eundersander
commented
Mar 13, 2021
| echo "Or:" | ||
| echo "python3 -m http.server" | ||
| echo "Then open in browser:" | ||
| echo "http://0.0.0.0:8000/build_js/utils/viewer/viewer.html?scene=skokloster-castle.glb" |
Contributor
Author
There was a problem hiding this comment.
I removed this reference to viewer.html. I consider it deprecated and it's not a good starting point for JS anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is work from @BlaiseRitchie plus some cleanup. 6-DOF headset-tracking plus gamepad buttons for turning and moving forward. See original PR: #1076
How Has This Been Tested
Tested with Ubuntu Chrome WebXR emulator, Android Chrome WebXR, and Quest 2 Oculus Browser WebXR.
Types of changes
Checklist