--Scene Dataset Config paths glob/wildcard handling#1152
Merged
jturner65 merged 5 commits intofacebookresearch:masterfrom Mar 25, 2021
Merged
--Scene Dataset Config paths glob/wildcard handling#1152jturner65 merged 5 commits intofacebookresearch:masterfrom
jturner65 merged 5 commits intofacebookresearch:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
mosra
reviewed
Mar 23, 2021
Contributor
mosra
left a comment
mosra
left a comment
There was a problem hiding this comment.
The glob() API usage is simpler than I expected, nice.
| #ifndef ESP_IO_IO_H_ | ||
| #define ESP_IO_IO_H_ | ||
|
|
||
| #include <glob.h> |
Contributor
There was a problem hiding this comment.
Can be in the cpp instead :)
| /** | ||
| * @brief This function will perform globbing on a passed path + pattern, | ||
| * returning all the files and directories that match the pattern. | ||
| * @param pattern The pattern to match |
Contributor
There was a problem hiding this comment.
Maybe mention what is allowed in the pattern? As in, it's just wildcards and not full regular expressions.
Contributor
Author
There was a problem hiding this comment.
Is there a way in the docs to put an external html link? (I was thinking of linking wiki :D )
Contributor
There was a problem hiding this comment.
It's a standard Markdown, so [title](url) works. Or just put an URL there directly.
Skylion007
approved these changes
Mar 25, 2021
Contributor
Skylion007
left a comment
Skylion007
left a comment
There was a problem hiding this comment.
Looks pretty good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds the ability to provide glob wildcards in the scene dataset configuration for the paths to specific configs, enabling wild-card-based searches and loads for configs that may be spread across many directories, such as per-stage paths that exist in Mp3d and HM3D datsets. See the newly added config file data/test_assets/dataset_tests/dataset_1/test_dataset_1.scene_dataset_config.json for usage examples.
How Has This Been Tested
C++ and python tests pass
Types of changes
Checklist