Skip to content

[Sensor][PYTHON][GFX] FishEyeSensor Bindings#1168

Merged
Skylion007 merged 19 commits intomasterfrom
fisheye_python
Apr 15, 2021
Merged

[Sensor][PYTHON][GFX] FishEyeSensor Bindings#1168
Skylion007 merged 19 commits intomasterfrom
fisheye_python

Conversation

@Skylion007
Copy link
Copy Markdown
Contributor

@Skylion007 Skylion007 commented Apr 12, 2021

Motivation and Context

  • Adds Python bindings for FishEye Sensor

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Need to lock in generation of ground truth.

@Skylion007 Skylion007 requested review from aclegg3 and bigbike April 12, 2021 16:54
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 12, 2021
@bigbike bigbike changed the title [PYTHON][GFX] FishEyeSensor Bindings [Sensor][PYTHON][GFX] FishEyeSensor Bindings Apr 12, 2021
Comment thread src/esp/bindings/SensorBindings.cpp
Comment thread examples/settings.py Outdated
Comment thread src/esp/bindings/SensorBindings.cpp Outdated
Comment thread examples/settings.py Outdated
Comment thread examples/settings.py
Comment thread src/esp/bindings/SensorBindings.cpp Outdated
Comment thread src/esp/bindings/SensorBindings.cpp
Comment thread tests/test_sensors.py Outdated
Comment thread examples/settings.py Outdated
@bigbike
Copy link
Copy Markdown
Contributor

bigbike commented Apr 13, 2021

Also, it would be awesome if we can add this new fisheye sensor to the colab tutorial, e.g., in the navigation section.

@Skylion007
Copy link
Copy Markdown
Contributor Author

BTW, wanted to give a heads up to @matsuren about this if you want to help implement any other sensors/shaders. This looks like it will be at least 3X as fast the ObservationTransformer hack. :)

@Skylion007 Skylion007 merged commit a0f09ca into master Apr 15, 2021
@Skylion007 Skylion007 deleted the fisheye_python branch April 15, 2021 00:59
@matsuren
Copy link
Copy Markdown

Hi @Skylion007, thank you for the information! It's awesome that it's written in C++ with shaders!

@Skylion007
Copy link
Copy Markdown
Contributor Author

Skylion007 commented Apr 20, 2021

@matsuren If there are any other shaders you would be interested in contributing like (Omnidirectional Stereo or such), let us know. Would be happy to help get it merged.

@matsuren
Copy link
Copy Markdown

@Skylion007 Thank you! I will let you know when I have something in my mind. (recently, I'm swamped with other projects, so I hope I can contribute in the future;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants