[Sensor][PYTHON][GFX] FishEyeSensor Bindings#1168
Merged
Skylion007 merged 19 commits intomasterfrom Apr 15, 2021
Merged
Conversation
Skylion007
commented
Apr 12, 2021
bigbike
reviewed
Apr 13, 2021
bigbike
reviewed
Apr 13, 2021
erikwijmans
reviewed
Apr 13, 2021
bigbike
approved these changes
Apr 13, 2021
Contributor
|
Also, it would be awesome if we can add this new fisheye sensor to the colab tutorial, e.g., in the navigation section. |
Contributor
Author
|
BTW, wanted to give a heads up to @matsuren about this if you want to help implement any other sensors/shaders. This looks like it will be at least 3X as fast the ObservationTransformer hack. :) |
|
Hi @Skylion007, thank you for the information! It's awesome that it's written in C++ with shaders! |
Contributor
Author
|
@matsuren If there are any other shaders you would be interested in contributing like (Omnidirectional Stereo or such), let us know. Would be happy to help get it merged. |
|
@Skylion007 Thank you! I will let you know when I have something in my mind. (recently, I'm swamped with other projects, so I hope I can contribute in the future;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested
Types of changes
Checklist
Need to lock in generation of ground truth.