Skip to content

[BUGFIX] Fix Voxel grid test failing when --vhacd not enabled.#1172

Merged
jturner65 merged 1 commit intofacebookresearch:masterfrom
jturner65:VoxelGrid_TestFix
Apr 15, 2021
Merged

[BUGFIX] Fix Voxel grid test failing when --vhacd not enabled.#1172
jturner65 merged 1 commit intofacebookresearch:masterfrom
jturner65:VoxelGrid_TestFix

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

VoxelGridTest was failing if --vhacd was not enabled (with no actual tests to run, the test suite considers this a failure), so this PR does not compile the test unless it has --vhacd is enabled. All compiler directives in the test file were removed as well, since they were not necessary.

How Has This Been Tested

C++ and python tests with and without flag passed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested review from aclegg3 and mosra April 15, 2021 15:05
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 15, 2021
@jturner65 jturner65 changed the title [BUGFIX] Fix Voxel grid failing when --vhacd not enabled. [BUGFIX] Fix Voxel grid test failing when --vhacd not enabled. Apr 15, 2021
@aclegg3
Copy link
Copy Markdown
Contributor

aclegg3 commented Apr 15, 2021

I didn't realize this was failing without --vhacd, thanks for catching this. However, I think there is still value to testing non-vhacd dependent functionality. Users can still create and access voxel grids, they just can't auto-compute a boundary grid.

@jturner65
Copy link
Copy Markdown
Contributor Author

I didn't realize this was failing without --vhacd, thanks for catching this. However, I think there is still value to testing non-vhacd dependent functionality. Users can still create and access voxel grids, they just can't auto-compute a boundary grid.

Unfortunately none of the authored tests can run without VHACD, so without a valid test the test suite will always fail.

@aclegg3
Copy link
Copy Markdown
Contributor

aclegg3 commented Apr 15, 2021

I didn't realize this was failing without --vhacd, thanks for catching this. However, I think there is still value to testing non-vhacd dependent functionality. Users can still create and access voxel grids, they just can't auto-compute a boundary grid.

Unfortunately none of the authored tests can run without VHACD, so without a valid test the test suite will always fail.

Yeah, I think some of that non-vhacd functionality could be split out into a separate test but for now this fix seems fine. The CI will test with vhacd anyway, so we won't miss issues there.

@jturner65 jturner65 merged commit c03afef into facebookresearch:master Apr 15, 2021
@jturner65 jturner65 deleted the VoxelGrid_TestFix branch April 15, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants