[BUGFIX] Fix Voxel grid test failing when --vhacd not enabled.#1172
[BUGFIX] Fix Voxel grid test failing when --vhacd not enabled.#1172jturner65 merged 1 commit intofacebookresearch:masterfrom
Conversation
|
I didn't realize this was failing without |
Unfortunately none of the authored tests can run without VHACD, so without a valid test the test suite will always fail. |
Yeah, I think some of that non-vhacd functionality could be split out into a separate test but for now this fix seems fine. The CI will test with vhacd anyway, so we won't miss issues there. |
Motivation and Context
VoxelGridTest was failing if --vhacd was not enabled (with no actual tests to run, the test suite considers this a failure), so this PR does not compile the test unless it has --vhacd is enabled. All compiler directives in the test file were removed as well, since they were not necessary.
How Has This Been Tested
C++ and python tests with and without flag passed.
Types of changes
Checklist