Skip to content

[Sensor] Fisheye and Equirectangular semantic sensors#1221

Merged
bigbike merged 50 commits intomasterfrom
semantic-fisheye
May 12, 2021
Merged

[Sensor] Fisheye and Equirectangular semantic sensors#1221
bigbike merged 50 commits intomasterfrom
semantic-fisheye

Conversation

@bigbike
Copy link
Copy Markdown
Contributor

@bigbike bigbike commented May 7, 2021

Motivation and Context

This diff does the following stuffs:

  • developed 2 new sensors: fisheye semantic sensor, and equirectangular semantic sensor;
  • developed new visualization functionality to visualize the semantic info from the aforementioned sensors;
  • added demos in the utility viewer (We chose parameters for "GoPro" in our demo);
  • small fixes;

The results are as follows:
fe-color
fe-semantic
eRec-color
eRec-semantic

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bigbike bigbike requested review from aclegg3 and removed request for aclegg3 May 7, 2021 22:43
@Skylion007
Copy link
Copy Markdown
Contributor

@bigbike This ended up being a bit more involved so I added the tests myself.

Comment thread examples/settings.py
Comment thread examples/settings.py
Comment thread examples/settings.py
Comment thread examples/settings.py Outdated
@erikwijmans
Copy link
Copy Markdown
Contributor

@bigbike @Skylion007 looks like this is going to revert #1222 ?

@Skylion007
Copy link
Copy Markdown
Contributor

@erikwijmans Fixed.

@bigbike Your changes reminded me that the SensorSpec has a channels property that weren't setting with Python or Habitat-Lab so I tried to update the example to set it. Interestingly, whenever I see it to 3 channels it crashes.

@bigbike
Copy link
Copy Markdown
Contributor Author

bigbike commented May 11, 2021

@bigbike Your changes reminded me that the SensorSpec has a channels property that weren't setting with Python or Habitat-Lab so I tried to update the example to set it. Interestingly, whenever I see it to 3 channels it crashes.

This is because the default value for channel should be 4 not 3 because there is an alpha channel. See here:
https://github.com/facebookresearch/habitat-sim/blob/master/src/esp/sensor/VisualSensor.h#L35-L38

@Skylion007
Copy link
Copy Markdown
Contributor

LGTM: Let's merge.

Comment thread examples/settings.py Outdated
@Skylion007
Copy link
Copy Markdown
Contributor

@bigbike It all passed except for that flakey codecov upload.

@bigbike
Copy link
Copy Markdown
Contributor Author

bigbike commented May 12, 2021

@Skylion007 : I re-ran the CI. It passed all the tests. Now it is ready to be committed. THANK YOU very much for contributing to this big PR as well! I sincerely appreciate it.

Merge it in.

@bigbike bigbike merged commit 3795955 into master May 12, 2021
@bigbike bigbike deleted the semantic-fisheye branch May 12, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants