Skip to content

[CI] Improved mypy typing#1241

Merged
Skylion007 merged 10 commits intomasterfrom
improved_mypy_typing
May 14, 2021
Merged

[CI] Improved mypy typing#1241
Skylion007 merged 10 commits intomasterfrom
improved_mypy_typing

Conversation

@Skylion007
Copy link
Copy Markdown
Contributor

Motivation and Context

  • With typeguard removed, we should rely more on static type checking. This fixes a bunch of type issues to get mypy properly working with habitat_sim. Mainly we install mypy along with all the requirements so that it can compare the types of imported libraries like Numpy and Torch. We then install it and add it the python-linter checks. We ran it as a pre-commit before, but that would run in a virtualenv without dependencies of the project and therefore could miss things.

How Has This Been Tested

  • CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)sting functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 14, 2021
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skylion007 Skylion007 merged commit 55cf558 into master May 14, 2021
@Skylion007 Skylion007 deleted the improved_mypy_typing branch May 14, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants