Skip to content

Improve Metadata Mediator Testing#1243

Merged
jturner65 merged 2 commits intofacebookresearch:masterfrom
jturner65:MM_ImproveMMTest
May 17, 2021
Merged

Improve Metadata Mediator Testing#1243
jturner65 merged 2 commits intofacebookresearch:masterfrom
jturner65:MM_ImproveMMTest

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

This PR expands the MM tests while making them more efficient and faster. It also specifically tests glob file wildcard loading from scene dataset configuration files.

How Has This Been Tested

All existing c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 17, 2021
@jturner65 jturner65 requested review from Skylion007 and aclegg3 May 17, 2021 17:17
@jturner65 jturner65 merged commit 7db138a into facebookresearch:master May 17, 2021
@jturner65 jturner65 deleted the MM_ImproveMMTest branch May 17, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants