Merged
Conversation
facebook-github-bot
added
the
CLA Signed
Skylion007
reviewed
May 20, 2021
Skylion007
approved these changes
May 20, 2021
jturner65
approved these changes
May 21, 2021
Contributor
jturner65
left a comment
jturner65
left a comment
There was a problem hiding this comment.
LGTM. Just one comment regarding the enumerators for PhysicsSimulationLibrary.
| @ref RigidObject implementing the specific interface to a simulation library. | ||
| */ | ||
| enum PhysicsSimulationLibrary { | ||
| enum class PhysicsSimulationLibrary { |
Contributor
There was a problem hiding this comment.
Would now be a good time to refactor these enumerators to be Pascal case?
Contributor
Author
There was a problem hiding this comment.
Fun migration. Need to work around the None keyword in python. Refactoring to NoPhysics instead.
Contributor
Author
There was a problem hiding this comment.
BTW, I'm leaving the config and metadata tag "none" for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ArticulatedObject migration PR split from #1226.
Contains all minor, straightforward changes from #1247:
How Has This Been Tested
Current tests should cover most of this.
Types of changes
Checklist