Merged
Conversation
Contributor
eundersander
left a comment
There was a problem hiding this comment.
A couple hacks here that I'd rather not see merged to master. If you are under a time crunch and need to merge as-is, let's at least document the tech debt somewhere.
added 2 commits
May 21, 2021 12:21
Merge remote-tracking branch 'origin/master' into ao-migration-contact-points
eundersander
approved these changes
May 24, 2021
Contributor
eundersander
left a comment
There was a problem hiding this comment.
Your plan to remove the logging sounds good. The rest looks good, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ArticulatedObject migration PR split from #1226.
Contains all contact point query related changes from #1247 originally implemented by @eundersander.
Note: I extracted functionality from BulletDebugManager to keep this isolated.
How Has This Been Tested
Added a C++ unit test.
Types of changes
Checklist