Skip to content

[AO migration] query contact points#1257

Merged
aclegg3 merged 5 commits intomasterfrom
ao-migration-contact-points
May 24, 2021
Merged

[AO migration] query contact points#1257
aclegg3 merged 5 commits intomasterfrom
ao-migration-contact-points

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented May 21, 2021

Motivation and Context

ArticulatedObject migration PR split from #1226.
Contains all contact point query related changes from #1247 originally implemented by @eundersander.

Note: I extracted functionality from BulletDebugManager to keep this isolated.

How Has This Been Tested

Added a C++ unit test.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested review from eundersander and jturner65 May 21, 2021 00:18
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 21, 2021
Copy link
Copy Markdown
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple hacks here that I'd rather not see merged to master. If you are under a time crunch and need to merge as-is, let's at least document the tech debt somewhere.

Comment thread src/esp/physics/bullet/BulletPhysicsManager.cpp Outdated
Comment thread src/esp/physics/bullet/BulletPhysicsManager.cpp Outdated
Alexander William Clegg added 2 commits May 21, 2021 12:21
Merge remote-tracking branch 'origin/master' into ao-migration-contact-points
Copy link
Copy Markdown
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your plan to remove the logging sounds good. The rest looks good, too.

@aclegg3 aclegg3 merged commit 1f5eae8 into master May 24, 2021
@aclegg3 aclegg3 deleted the ao-migration-contact-points branch May 24, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants