--Save Physics Objects' Scene Instancing attributes on placement#1274
Merged
jturner65 merged 2 commits intofacebookresearch:masterfrom May 27, 2021
Merged
--Save Physics Objects' Scene Instancing attributes on placement#1274jturner65 merged 2 commits intofacebookresearch:masterfrom
jturner65 merged 2 commits intofacebookresearch:masterfrom
Conversation
jturner65
commented
May 27, 2021
| * instance or nullptr if no template exists. | ||
| */ | ||
| template <class T> | ||
| std::shared_ptr<T> getSceneInstanceAttrInternal() const { |
Contributor
Author
There was a problem hiding this comment.
This is here to cater to Articulated Objects, which use a SceneAOInstanceAttributes, which inherits from SceneObjectInstanceAttributes. Nice to have access to the instance attributes cast appropriately for immediate access.
Skylion007
reviewed
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR improves how objects are instanced. It also introduces the ability to save the scene object instance attributes used to place an object to the object itself. This will make it easier in the future to return an object to its initial position.
How Has This Been Tested
All c++ and python tests pass
Types of changes
Checklist