Skip to content

--Save Physics Objects' Scene Instancing attributes on placement#1274

Merged
jturner65 merged 2 commits intofacebookresearch:masterfrom
jturner65:ObjSceneInstAttr
May 27, 2021
Merged

--Save Physics Objects' Scene Instancing attributes on placement#1274
jturner65 merged 2 commits intofacebookresearch:masterfrom
jturner65:ObjSceneInstAttr

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

This PR improves how objects are instanced. It also introduces the ability to save the scene object instance attributes used to place an object to the object itself. This will make it easier in the future to return an object to its initial position.

How Has This Been Tested

All c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested review from Skylion007 and aclegg3 May 27, 2021 18:58
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 27, 2021
* instance or nullptr if no template exists.
*/
template <class T>
std::shared_ptr<T> getSceneInstanceAttrInternal() const {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here to cater to Articulated Objects, which use a SceneAOInstanceAttributes, which inherits from SceneObjectInstanceAttributes. Nice to have access to the instance attributes cast appropriately for immediate access.

Comment thread src/esp/physics/RigidStage.h Outdated
@jturner65 jturner65 requested a review from Skylion007 May 27, 2021 19:48
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jturner65 jturner65 merged commit 51df239 into facebookresearch:master May 27, 2021
@jturner65 jturner65 deleted the ObjSceneInstAttr branch May 27, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants