Skip to content

[GFX][FisheyeBindings] Allow principal point to default to center of sensor#1291

Merged
Skylion007 merged 11 commits intomasterfrom
improved_fisheye_bindings
Jun 3, 2021
Merged

[GFX][FisheyeBindings] Allow principal point to default to center of sensor#1291
Skylion007 merged 11 commits intomasterfrom
improved_fisheye_bindings

Conversation

@Skylion007
Copy link
Copy Markdown
Contributor

Motivation and Context

  • We currently have to specify the Principal Point which is a big annoyance on the Habitat-Lab side. Most of the time, the principal point should lie in the center of the image. If not, the user can still specify it. Using the new fixed Corrade::Optional bindings to make this a sensible and easy to compute default.

How Has This Been Tested

  • PyTest and locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 3, 2021
@Skylion007 Skylion007 requested a review from aclegg3 June 3, 2021 16:57
@Skylion007 Skylion007 requested a review from erikwijmans June 3, 2021 17:50
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@bigbike bigbike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if you need to upgrade the viewer.cpp as well.

Comment thread src/esp/sensor/FisheyeSensor.cpp Outdated
Comment thread src/esp/sensor/FisheyeSensor.cpp Outdated
Comment thread src/esp/sensor/FisheyeSensor.h Outdated
Comment thread examples/settings.py
@bigbike
Copy link
Copy Markdown
Contributor

bigbike commented Jun 3, 2021

@Skylion007 :
Last thing: check the viewer.cpp.
Then you are good to merge it. :)

Thanks a lot!

@Skylion007 Skylion007 merged commit f568b65 into master Jun 3, 2021
@Skylion007 Skylion007 deleted the improved_fisheye_bindings branch June 3, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants