Skip to content

[bugfix] update VHACD tutorial script#1294

Merged
aclegg3 merged 4 commits intomasterfrom
vhacd-api-updates
Jun 4, 2021
Merged

[bugfix] update VHACD tutorial script#1294
aclegg3 merged 4 commits intomasterfrom
vhacd-api-updates

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Jun 4, 2021

Motivation and Context

Apply recent API changes and add the tutorial to test_examples so future issues will be caught by CI.

How Has This Been Tested

New CI coverage.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 June 4, 2021 16:14
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 4, 2021
Comment thread tests/test_examples.py Outdated
Comment thread tests/test_examples.py Outdated
@aclegg3 aclegg3 merged commit a6ff11b into master Jun 4, 2021
@aclegg3 aclegg3 deleted the vhacd-api-updates branch June 4, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants