Skip to content

[Pre-commit][CI] check-xml and requirements update#1301

Merged
Skylion007 merged 4 commits into
masterfrom
pre-commit-check-xml
Jun 8, 2021
Merged

[Pre-commit][CI] check-xml and requirements update#1301
Skylion007 merged 4 commits into
masterfrom
pre-commit-check-xml

Conversation

@Skylion007

Copy link
Copy Markdown
Contributor

Motivation and Context

  • As we begin to add URDF files to the data folder, this adds a check to ensure that they are valid XML. I added URDF as an xml file tag on the pre-commit identify repo so it should recognize them as XML. All it does will check if the XML is parsable.
  • Autoupdates some pre-commit
  • Remove deprecated extras requirement from isort.
    Should be useful for [AO migration] URDF Parser + Model #1300 and other PRs that introduce URDF

How Has This Been Tested

  • CI and locally with pytest

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 8, 2021

@jturner65 jturner65 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shouldn't be hard to maintain proper xml.

@Skylion007 Skylion007 merged commit 48e92e6 into master Jun 8, 2021
@Skylion007 Skylion007 deleted the pre-commit-check-xml branch June 8, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants