[Bugfix] Specify default stage shader type as flat;#1307
Merged
jturner65 merged 1 commit intofacebookresearch:masterfrom Jun 10, 2021
Merged
[Bugfix] Specify default stage shader type as flat;#1307jturner65 merged 1 commit intofacebookresearch:masterfrom
jturner65 merged 1 commit intofacebookresearch:masterfrom
Conversation
Skylion007
approved these changes
Jun 10, 2021
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Small bugfix that specifies a stage's default shader type to be flat instead of unknown. Since stages often come with lighting baked into the textures, we do not want to apply phong or pbr shading on top of this. This, of course, can be easily overridden, either at the stage config level, or for individual instancing scenes.
REVERTED BY 1311
How Has This Been Tested
All c++ and python tests pass locally
Types of changes
Checklist