Skip to content

[Bugfix] Specify default stage shader type as flat;#1307

Merged
jturner65 merged 1 commit intofacebookresearch:masterfrom
jturner65:Bugfix_StageDfltShader
Jun 10, 2021
Merged

[Bugfix] Specify default stage shader type as flat;#1307
jturner65 merged 1 commit intofacebookresearch:masterfrom
jturner65:Bugfix_StageDfltShader

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 commented Jun 10, 2021

Motivation and Context

Small bugfix that specifies a stage's default shader type to be flat instead of unknown. Since stages often come with lighting baked into the textures, we do not want to apply phong or pbr shading on top of this. This, of course, can be easily overridden, either at the stage config level, or for individual instancing scenes.

REVERTED BY 1311

How Has This Been Tested

All c++ and python tests pass locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 10, 2021
@jturner65 jturner65 requested a review from aclegg3 June 10, 2021 19:07
@jturner65 jturner65 changed the title --specify default stage shader type as flat; [Bugfix] Specify default stage shader type as flat; Jun 10, 2021
@jturner65 jturner65 merged commit 2ef8610 into facebookresearch:master Jun 10, 2021
@jturner65 jturner65 deleted the Bugfix_StageDfltShader branch June 10, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants