Skip to content

Create Appropriate PrimitiveAssetAttributes from valid handle#1314

Merged
jturner65 merged 4 commits intofacebookresearch:masterfrom
jturner65:Prims_CreateAttrFromName
Jun 15, 2021
Merged

Create Appropriate PrimitiveAssetAttributes from valid handle#1314
jturner65 merged 4 commits intofacebookresearch:masterfrom
jturner65:Prims_CreateAttrFromName

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

This small PR will take a valid PrimitiveAssetAttributes handle and use it to create and configure an appropriate PrimitiveAssetAttributes template. The handles of these templates encode all the relevant information required to properly instantiate a Magnum Primitive, and the handles cannot be changed by the user, so these handles can be expected to be valid descriptions/encodings of the described primitive template.

How Has This Been Tested

All c++ and python tests pass. C++ tests have been added to verify that template handles can be parsed into templates with appropriate field values.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 June 14, 2021 23:13
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 14, 2021
@jturner65 jturner65 changed the title Prims create attr from name Create Appropriate PrimitiveAssetAttributes from valid handle Jun 14, 2021
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aclegg3 aclegg3 mentioned this pull request Jun 14, 2021
11 tasks
@jturner65 jturner65 merged commit 48a6b6c into facebookresearch:master Jun 15, 2021
@jturner65 jturner65 deleted the Prims_CreateAttrFromName branch June 15, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants