Create Appropriate PrimitiveAssetAttributes from valid handle#1314
Merged
jturner65 merged 4 commits intofacebookresearch:masterfrom Jun 15, 2021
Merged
Create Appropriate PrimitiveAssetAttributes from valid handle#1314jturner65 merged 4 commits intofacebookresearch:masterfrom
jturner65 merged 4 commits intofacebookresearch:masterfrom
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This small PR will take a valid PrimitiveAssetAttributes handle and use it to create and configure an appropriate PrimitiveAssetAttributes template. The handles of these templates encode all the relevant information required to properly instantiate a Magnum Primitive, and the handles cannot be changed by the user, so these handles can be expected to be valid descriptions/encodings of the described primitive template.
How Has This Been Tested
All c++ and python tests pass. C++ tests have been added to verify that template handles can be parsed into templates with appropriate field values.
Types of changes
Checklist