Skip to content

Add --no-replace to datasets_download.py #1362

Merged
aclegg3 merged 4 commits intomasterfrom
datasets_download-no-replace
Jun 30, 2021
Merged

Add --no-replace to datasets_download.py #1362
aclegg3 merged 4 commits intomasterfrom
datasets_download-no-replace

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Jun 30, 2021

Motivation and Context

Add --no-replace to datasets_download.py to skip existing data automatically. Should fix use-cases with automated download that are run multiple times, currently requiring re-download with --replace or crashing due to user prompt.

How Has This Been Tested

Locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 30, 2021
Comment thread habitat_sim/utils/datasets_download.py Outdated
@aclegg3 aclegg3 requested a review from Skylion007 June 30, 2021 18:03
Comment thread habitat_sim/utils/datasets_download.py Outdated
Comment thread habitat_sim/utils/datasets_download.py Outdated
aclegg3 and others added 2 commits June 30, 2021 11:12
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
@aclegg3 aclegg3 merged commit 567e5f2 into master Jun 30, 2021
@aclegg3 aclegg3 deleted the datasets_download-no-replace branch June 30, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants