Skip to content

Add way to download data for the hand demo#1365

Merged
ldcWV merged 5 commits intofacebookresearch:masterfrom
ldcWV:ldchen/webxr_hand_demo_dataset
Jul 15, 2021
Merged

Add way to download data for the hand demo#1365
ldcWV merged 5 commits intofacebookresearch:masterfrom
ldcWV:ldchen/webxr_hand_demo_dataset

Conversation

@ldcWV
Copy link
Copy Markdown
Contributor

@ldcWV ldcWV commented Jul 1, 2021

Motivation and Context

Very small PR that adds a way to download the data needed for the WebXR Hand Demo, which is here: #1366

The command used to download the data will be

python -m habitat_sim.utils.datasets_download --uids webxr_hand_demo --data-path examples/web_apps/webxr_hand_demo/data

This will create examples/web_apps/webxr_hand_demo/data/webxr_hand_demo_dataset with the necessary files inside.

How Has This Been Tested

I ran the dataset downloader and it worked.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 1, 2021
@ldcWV ldcWV marked this pull request as ready for review July 1, 2021 00:42
@ldcWV ldcWV requested a review from eundersander July 1, 2021 00:42
Comment thread habitat_sim/utils/datasets_download.py Outdated
@ldcWV ldcWV requested a review from eundersander July 13, 2021 00:08
Copy link
Copy Markdown
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldcWV ldcWV merged commit b5e256a into facebookresearch:master Jul 15, 2021
@ldcWV ldcWV deleted the ldchen/webxr_hand_demo_dataset branch July 15, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants