datasets_download.py - change default data_path #1369
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
mathfac
approved these changes
Jul 2, 2021
| data_path = args.data_path | ||
| if not data_path: | ||
| try: | ||
| import git |
Contributor
There was a problem hiding this comment.
Maybe, we can do both, check git repo first, and then use ./data/ as fall back?
7 tasks
Skylion007
reviewed
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Change default data_path from git to ./data/ so the script has a reasonable default outside of git repo but is also compatible with previous default behavior in habitat-sim directory and doesn't flood an existing user directory.
How Has This Been Tested
Locally
Types of changes
Checklist