Skip to content

Upgrade Pybind11 to 2.7#1388

Merged
Skylion007 merged 1 commit intomasterfrom
pybind_27_update
Jul 16, 2021
Merged

Upgrade Pybind11 to 2.7#1388
Skylion007 merged 1 commit intomasterfrom
pybind_27_update

Conversation

@Skylion007
Copy link
Copy Markdown
Contributor

@Skylion007 Skylion007 commented Jul 16, 2021

Motivation and Context

Dependency update. It adds a bunch of new features to PyBind11 and also applies a whole bunch of optimizations to it. See the changelog for more info: https://github.com/pybind/pybind11/blob/master/docs/changelog.rst

How Has This Been Tested

  • Locally and with CI

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 16, 2021
@Skylion007 Skylion007 requested a review from bigbike July 16, 2021 20:35
Copy link
Copy Markdown
Contributor

@bigbike bigbike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No source code needs to be reviewed.
I assume @Skylion007 does not make any mistake here. :)

@Skylion007
Copy link
Copy Markdown
Contributor Author

No source code needs to be reviewed.
I assume @Skylion007 does not make any mistake here. :)

Hey, if it passes Google's Company Wide Test Suite probably good enough for us.

@Skylion007 Skylion007 merged commit 88405af into master Jul 16, 2021
@Skylion007 Skylion007 deleted the pybind_27_update branch July 16, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants