--Add support for nested User-defined attributes#1413
Merged
jturner65 merged 4 commits intofacebookresearch:masterfrom Jul 29, 2021
Merged
--Add support for nested User-defined attributes#1413jturner65 merged 4 commits intofacebookresearch:masterfrom
jturner65 merged 4 commits intofacebookresearch:masterfrom
Conversation
c6742f3 to
f6e81df
Compare
f6e81df to
06fc738
Compare
Skylion007
reviewed
Jul 29, 2021
Skylion007
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Presently, the user-defined attributes fields within the various configuration files only support a single layer of data values of various types, but this PR adds support for nested json objects within user-defined attributes values, enabling a user to be able to specify sub-groupings within these fields.
This functionality is required for ReplicaCAD to be properly used in Habitat 2.0 (to provide support for per-object placement box configurations)
How Has This Been Tested
Tests added in c++ to verify functionality. Tested locally c++ and python
Types of changes
Checklist