Skip to content

--Add support for nested User-defined attributes#1413

Merged
jturner65 merged 4 commits intofacebookresearch:masterfrom
jturner65:SD_ArtObjInstUserData
Jul 29, 2021
Merged

--Add support for nested User-defined attributes#1413
jturner65 merged 4 commits intofacebookresearch:masterfrom
jturner65:SD_ArtObjInstUserData

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

Presently, the user-defined attributes fields within the various configuration files only support a single layer of data values of various types, but this PR adds support for nested json objects within user-defined attributes values, enabling a user to be able to specify sub-groupings within these fields.

This functionality is required for ReplicaCAD to be properly used in Habitat 2.0 (to provide support for per-object placement box configurations)

How Has This Been Tested

Tests added in c++ to verify functionality. Tested locally c++ and python

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested review from Skylion007 and aclegg3 July 29, 2021 03:50
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 29, 2021
@jturner65 jturner65 changed the title Add support for nested User-defined attributes --Add support for nested User-defined attributes Jul 29, 2021
@jturner65 jturner65 force-pushed the SD_ArtObjInstUserData branch 2 times, most recently from c6742f3 to f6e81df Compare July 29, 2021 11:00
@jturner65 jturner65 force-pushed the SD_ArtObjInstUserData branch from f6e81df to 06fc738 Compare July 29, 2021 11:04
@jturner65 jturner65 requested review from eundersander and mosra July 29, 2021 14:06
Comment thread src/esp/io/json.cpp
@jturner65 jturner65 merged commit e54a517 into facebookresearch:master Jul 29, 2021
@jturner65 jturner65 deleted the SD_ArtObjInstUserData branch July 29, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants