Skip to content

[bugfix] fix overlay_settings not being forwarded#1422

Merged
aclegg3 merged 1 commit intomasterfrom
bugfix-viz-utils
Aug 5, 2021
Merged

[bugfix] fix overlay_settings not being forwarded#1422
aclegg3 merged 1 commit intomasterfrom
bugfix-viz-utils

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Aug 4, 2021

Motivation and Context

As identified by #1421, overlay_settings was not being forwarded during video creation.

How Has This Been Tested

Locally with ECCV_2020_Interactivity.py

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from Skylion007 August 4, 2021 15:35
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 4, 2021
@aclegg3 aclegg3 merged commit c214bf5 into master Aug 5, 2021
@aclegg3 aclegg3 deleted the bugfix-viz-utils branch August 5, 2021 20:04
@QingquanBao
Copy link
Copy Markdown

Hi, could you check whether the latest version has synced this bug-fix? I use conda to install AI Habitat in March 2022, i.e., conda install habitat-sim withbullet headless -c conda-forge -c aihabitat, but this bug remains. Hope your reply, thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants