Skip to content

--[BugFix]Fix erroneous ConfigStoredType checks#1456

Merged
jturner65 merged 1 commit intofacebookresearch:masterfrom
jturner65:Configs_BugFix
Aug 28, 2021
Merged

--[BugFix]Fix erroneous ConfigStoredType checks#1456
jturner65 merged 1 commit intofacebookresearch:masterfrom
jturner65:Configs_BugFix

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

This small PR addresses a logic error in a check attempting to verify that all possible values of an enum are properly supported in switch statements of two functions.

How Has This Been Tested

Locally tested c++ and python

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 27, 2021
@jturner65 jturner65 requested review from bigbike and mosra August 27, 2021 20:42
@jturner65 jturner65 merged commit 41d046b into facebookresearch:master Aug 28, 2021
@jturner65 jturner65 deleted the Configs_BugFix branch August 28, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants