Skip to content

[Bugfix]--Add default entries into configuration#1547

Merged
jturner65 merged 1 commit intofacebookresearch:mainfrom
jturner65:Bugfix_AttributesInit
Oct 21, 2021
Merged

[Bugfix]--Add default entries into configuration#1547
jturner65 merged 1 commit intofacebookresearch:mainfrom
jturner65:Bugfix_AttributesInit

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 commented Oct 21, 2021

Motivation and Context

This PR adds 2 missing default (empty string) entries (for "navmesh_instance" and "semantic_scene_instance") in SceneInstanceAttributes so the configuration will not throw an error if these values are not present when queried.

How Has This Been Tested

C++ and python tests pass locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 October 21, 2021 21:38
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 21, 2021
@jturner65 jturner65 merged commit b198b21 into facebookresearch:main Oct 21, 2021
@jturner65 jturner65 deleted the Bugfix_AttributesInit branch October 21, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants