Fairmotion Character Positioning via MOTION MouseMode#1552
Merged
JuanTheEngineer merged 11 commits intomainfrom Nov 3, 2021
Merged
Fairmotion Character Positioning via MOTION MouseMode#1552JuanTheEngineer merged 11 commits intomainfrom
JuanTheEngineer merged 11 commits intomainfrom
Conversation
702eac1 to
d980785
Compare
Skylion007
previously requested changes
Nov 1, 2021
Contributor
|
FYI, just updated the Magnum color bindings to make things a bit easier for you: mosra/magnum-bindings@c50a2f6 . Will need to bump the submodule to see the new bindings. |
Resolved current change requests
Skylion007
reviewed
Nov 2, 2021
aclegg3
approved these changes
Nov 3, 2021
Contributor
aclegg3
left a comment
There was a problem hiding this comment.
Great video in description. Let's improve the UI description also. Be clear about which click and keys to use. Maybe use a bullet list similar to the help text.
When you re-defined the help text for this application you dropped the mouse legend. Let's add that back here and document the MOTION mode there.
JuanTheEngineer
added a commit
that referenced
this pull request
Nov 4, 2021
* Add MOTION mouse mode * Create and Remove functions for selector icon * Rotate and Translate feature in motion mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Goal
With this PR merged, the Fairmotion viewer will have an additional mouse interaction mode called "MOTION".
Functionality
This mode allows users to select a loaded Fairmotion character and click to a desired location for the character and its motion. It also allows users to set rotation around the floor-normal axis by scrolling the mouse wheel with fine-grain rotating using the Shift key. These are useful features for positioning the character in the scene.
It is works in parallel with the Key Frame and Trajectory Object Previews, which gives the user the ability to foresee scene collision throughout the timeline of the motion for improved character placement choice.
Currently the Fairmotion viewer supports one character at a time and this PR feature is lightly coupled to that fact. In a future PR multiple character loading will be supported and this MOTION mode with expand to the same degree.
UI Mouse Commands
Here is a snippet of the Command Help Text to describe the utilities of this PR
Preview
Here is a preview of the feature in action where the feature is used to place the character's dribbling motion in the tight hallway:
Demo_Motion_Mouse_Postioning.mp4
How Has This Been Tested
The majority of this feature lives in the Fairmotion viewer application and was tested by running that application.
Types of changes
Checklist