Skip to content

Fixing bug in python-viewer with draw event callable argument#1558

Merged
JuanTheEngineer merged 1 commit intomainfrom
python-viewer-debug
Nov 3, 2021
Merged

Fixing bug in python-viewer with draw event callable argument#1558
JuanTheEngineer merged 1 commit intomainfrom
python-viewer-debug

Conversation

@JuanTheEngineer
Copy link
Copy Markdown
Contributor

Motivation and Context

Quick fix to Python-Viewer which is currently not running because of an arguments error.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 3, 2021
@JuanTheEngineer JuanTheEngineer merged commit b1c5583 into main Nov 3, 2021
@JuanTheEngineer JuanTheEngineer deleted the python-viewer-debug branch November 3, 2021 16:36
@Skylion007
Copy link
Copy Markdown
Contributor

@JuanTheEngineer This isn't the best way to check for None types. It should have been if ___ is not None relying on the implicit boolean conversion of None is not recommended.

@Skylion007
Copy link
Copy Markdown
Contributor

As an aside, mypy should have really caught this. Wonder why it did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants