[Part 2 of 2]--SceneInstance snapshot and save.#1568
Merged
jturner65 merged 28 commits intofacebookresearch:mainfrom Nov 23, 2021
Merged
[Part 2 of 2]--SceneInstance snapshot and save.#1568jturner65 merged 28 commits intofacebookresearch:mainfrom
jturner65 merged 28 commits intofacebookresearch:mainfrom
Conversation
3df91f0 to
d86d51f
Compare
Skylion007
approved these changes
Nov 19, 2021
Skylion007
approved these changes
Nov 22, 2021
aclegg3
approved these changes
Nov 23, 2021
| } | ||
| /** | ||
| * @brief This will populate the passed @p sceneInstanceAttrs with the current | ||
| * stage, object and articulated object insttances reflecting the currernt |
Contributor
There was a problem hiding this comment.
Suggested change
| * stage, object and articulated object insttances reflecting the currernt | |
| * stage, object and articulated object instances reflecting the current |
Don't save superfluous/system-generated data values, just values the user would expect to edit.
31513b7 to
25a23c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR provides the functionality to build a scene instance from the current simulation state and to properly save that scene instance to a JSON file. Saving Attributes to JSON has also been improved for all appropriate Attributes classes.
Functionality being introduced :
Some extra information :
Viewer.cpp has been modified to provide a key-stroke to record the current scene instance, saving it to disk with the same name along with an increment (copy xxxx). Repeatedly saving the scene instance will increase the increment. An unintended, but welcome, consequence of this is that the newly saved scene instance is immediately available to cycle to via Tab/Shift-tab, where it will be loaded in and displayed.
A mechanism is also provided for saving with a new, user-provided, name, which will forcibly overwrite any existing scene instance configs with the same name.
How Has This Been Tested
Types of changes
Checklist