[Breaking Change][Refactor]--Remove all object manipulation functions from Simulator#1574
Merged
jturner65 merged 9 commits intofacebookresearch:mainfrom Dec 1, 2021
Merged
Conversation
These functions are now handled via RigidObjectManager
915e15b to
712ccf2
Compare
aclegg3
approved these changes
Nov 30, 2021
Contributor
aclegg3
left a comment
There was a problem hiding this comment.
Looks good to me. Nice to see this deprecated code removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With the introduction of the RigidObjectManager, accessing object-related functionality via simulator became redundant, and was deprecated. This PR removes the object-related functionality from Simulator and Simulator bindings. It also moves trajectory-related functionality to PhysicsManager, while retaining the addTrajectory and removeTrajectory stubs in simulator.
Note : This is a breaking change to how objects are instanced and removed via python/python bindings. All examples and tutorials had been updated this past summer to the new mechanism, and deprecation warnings had been added to context help for all affected functional bindings, but this PR removes the deprecated functions completely from both c++ and bindings.
Note : The protocol for accessing objects has NOT changed in javascript. This will be updated in a subsequent PR.
How Has This Been Tested
All existing c++ and python tests pass
Types of changes
Checklist