Skip to content

[Breaking Change][Refactor]--Remove all object manipulation functions from Simulator#1574

Merged
jturner65 merged 9 commits intofacebookresearch:mainfrom
jturner65:Sim_RemoveObjCreate
Dec 1, 2021
Merged

[Breaking Change][Refactor]--Remove all object manipulation functions from Simulator#1574
jturner65 merged 9 commits intofacebookresearch:mainfrom
jturner65:Sim_RemoveObjCreate

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 commented Nov 25, 2021

Motivation and Context

With the introduction of the RigidObjectManager, accessing object-related functionality via simulator became redundant, and was deprecated. This PR removes the object-related functionality from Simulator and Simulator bindings. It also moves trajectory-related functionality to PhysicsManager, while retaining the addTrajectory and removeTrajectory stubs in simulator.

Note : This is a breaking change to how objects are instanced and removed via python/python bindings. All examples and tutorials had been updated this past summer to the new mechanism, and deprecation warnings had been added to context help for all affected functional bindings, but this PR removes the deprecated functions completely from both c++ and bindings.

Note : The protocol for accessing objects has NOT changed in javascript. This will be updated in a subsequent PR.

How Has This Been Tested

All existing c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 25, 2021
@jturner65 jturner65 changed the title [WIP][Breaking Change][Refactor]--Remove all object manipulation functions from Simulator [Breaking Change][Refactor]--Remove all object manipulation functions from Simulator Nov 30, 2021
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice to see this deprecated code removed.

@jturner65 jturner65 merged commit 9567449 into facebookresearch:main Dec 1, 2021
@jturner65 jturner65 deleted the Sim_RemoveObjCreate branch December 1, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants