--Scene Dataset default attributes filename wildcard handling.#1584
Merged
jturner65 merged 4 commits intofacebookresearch:mainfrom Dec 2, 2021
Merged
--Scene Dataset default attributes filename wildcard handling.#1584jturner65 merged 4 commits intofacebookresearch:mainfrom
jturner65 merged 4 commits intofacebookresearch:mainfrom
Conversation
Skylion007
approved these changes
Dec 2, 2021
Contributor
Skylion007
left a comment
There was a problem hiding this comment.
Looks good to me. Also good job on making all the std::functions a const ref since they aren't trivially copyable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds support for a wildcard/sentinel value in the name of the render or collision asset for object attributes or stage attributes (or the navmesh, Semantic Scene asset or Semantic Scene Descriptor text file for stages) in the "default_attributes" tag of the Scene Dataset configuration file. This value, "%%CONFIG_NAME_AS_ASSET_FILENAME%%" will be replaced by the name used to synthesize the attributes upon instantiation, so a stage- or object-specific value can be requested at the Scene Dataset level, in one spot. Any value synthesized using this tag will be verified to actually exist before it is written (otherwise the field is cleared).
With datasets like HM3D, where the data is organized such that a scene's assets and other pertinent information is stored in a single directory specific to that scene, this enables fairly complex handling of subordinate assets without individual per-scene stage configurations.
All c++ and python tests pass. Verified to work with Appen POC HM3D scene annotations.
How Has This Been Tested
Types of changes
Checklist