[HM3D]--Semantic scene support/bugfixes.#1592
[HM3D]--Semantic scene support/bugfixes.#1592jturner65 merged 22 commits intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
SemanticSceneFixes
branch
from
305da6f to
d4fce20
Compare
| importerManager_.setPreferredPlugins("ObjImporter", {"AssimpImporter"}); | ||
| Cr::PluginManager::PluginMetadata* const assimpmetadata = | ||
| importerManager_.metadata("AssimpImporter"); | ||
| assimpmetadata->configuration().setValue("ImportColladaIgnoreUpDirection", |
There was a problem hiding this comment.
Hmm, I wish there was a way to use this if it wasn't specified in the JSON...
There was a problem hiding this comment.
Could you explain what you mean? Thanks :)
There was a problem hiding this comment.
I am worried the fact that other importers like Blender may support Collada's up direction may cause confusion for end-users when the rotations do not match. Seems like it's harmful to ignore an up direction defined in the dae. What about other formats that have their own up direction, it feels like we should try to be consistent with the handling of the up direction across formats. (For instance, the rotation in the dataset should be relative to the up direction in the mesh file).
There was a problem hiding this comment.
This flag is consistent with the current engine treatment (no change from this PR), so let's not block on this.
Context: It was necessary to get consistent behavior across a variety of URDF files. I agree we should re-visit this and ensure our handling is consistent with other importers in a later PR.
jturner65
force-pushed
the
SemanticSceneFixes
branch
4 times, most recently
from
53fa342 to
9af3d7a
Compare
With this PRs changes, Mp3d dataset requires SceneDatasetConfig specifying default semantic mesh orientation frame for all scenes.
jturner65
force-pushed
the
SemanticSceneFixes
branch
from
980a5ca to
c0fc869
Compare
4 participants
Motivation and Context
This PR adds various functions and refactors required to implement support for HM3D semantic scenes in the correct format. Included are :
Also, some refactors to improve efficiency and debug message content in Resource Manager are included.
How Has This Been Tested
Locally c++ and python tests
Types of changes
Checklist