[Bugfix]--Fix HM3D Semantic Object ID construction#1618
Merged
jturner65 merged 1 commit intofacebookresearch:mainfrom Jan 11, 2022
Merged
[Bugfix]--Fix HM3D Semantic Object ID construction#1618jturner65 merged 1 commit intofacebookresearch:mainfrom
jturner65 merged 1 commit intofacebookresearch:mainfrom
Conversation
aclegg3
approved these changes
Jan 11, 2022
Contributor
aclegg3
left a comment
There was a problem hiding this comment.
Looks good to me. We should add the PoC semantic scene to the test assets download so we can verify this stuff for future proofing. We have permission to distribute that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes how the Semantic Object ID is constructed for the HM3D dataset. Previously, it was constructing the Semantic Object ID to be "_" (i.e. "wall_1") but this was incorrect - the current standard in engine is to have the final value of the Semantic Object ID be a unique int across all categories, corresponding to the Semantic ID in the Scene Node. This PR fixes this.
How Has This Been Tested
Locally c++ and python tests pass.
Types of changes
Checklist