Skip to content

[Bugfix]--Fix HM3D Semantic Object ID construction#1618

Merged
jturner65 merged 1 commit intofacebookresearch:mainfrom
jturner65:Bugfix_HM3D_SSD
Jan 11, 2022
Merged

[Bugfix]--Fix HM3D Semantic Object ID construction#1618
jturner65 merged 1 commit intofacebookresearch:mainfrom
jturner65:Bugfix_HM3D_SSD

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 commented Jan 11, 2022

Motivation and Context

This PR fixes how the Semantic Object ID is constructed for the HM3D dataset. Previously, it was constructing the Semantic Object ID to be "_" (i.e. "wall_1") but this was incorrect - the current standard in engine is to have the final value of the Semantic Object ID be a unique int across all categories, corresponding to the Semantic ID in the Scene Node. This PR fixes this.

How Has This Been Tested

Locally c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 11, 2022
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should add the PoC semantic scene to the test assets download so we can verify this stuff for future proofing. We have permission to distribute that one.

@jturner65 jturner65 merged commit 92acb65 into facebookresearch:main Jan 11, 2022
@jturner65 jturner65 deleted the Bugfix_HM3D_SSD branch January 11, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants