Skip to content

[Bugfix]-- Fix semantic color map binds (arrayView -> const ref)#1654

Merged
jturner65 merged 3 commits intofacebookresearch:mainfrom
jturner65:Bugfix_SemanticColorMapBinds
Feb 4, 2022
Merged

[Bugfix]-- Fix semantic color map binds (arrayView -> const ref)#1654
jturner65 merged 3 commits intofacebookresearch:mainfrom
jturner65:Bugfix_SemanticColorMapBinds

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

Minor bugfix to address bindings to colormap query not working properly. Added python test to verify colormap is accessible through bindings.

How Has This Been Tested

Locally c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 4, 2022
@jturner65 jturner65 merged commit 30a4459 into facebookresearch:main Feb 4, 2022
@jturner65 jturner65 deleted the Bugfix_SemanticColorMapBinds branch February 4, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants