Skip to content

[Bugfix] Fix python bindings for OBB#1670

Merged
Skylion007 merged 4 commits intomainfrom
fix-obb-constructor-python
Feb 18, 2022
Merged

[Bugfix] Fix python bindings for OBB#1670
Skylion007 merged 4 commits intomainfrom
fix-obb-constructor-python

Conversation

@Skylion007
Copy link
Copy Markdown
Contributor

Motivation and Context

  • The constructor for OBB now takes a Magnum Quaternion. We don't have any casters from numpy-quaternion to Eigen::Quaternion. Therefore, the previous constructor could never be called. Now the user can pass a Magnum::Quaternion instead which we will cast to an Eigen equivalent.

How Has This Been Tested

  • Locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 18, 2022
@Skylion007 Skylion007 merged commit 91f322c into main Feb 18, 2022
@Skylion007 Skylion007 deleted the fix-obb-constructor-python branch February 18, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants