Properly use texture transformation matrix for flat materials as well.#1688
Merged
Properly use texture transformation matrix for flat materials as well.#1688
Conversation
facebook-github-bot
added
the
CLA Signed
mosra
force-pushed
the
flat-texturetransform
branch
from
65c3fc9 to
576d0fa
Compare
jturner65
reviewed
Mar 8, 2022
Comment on lines
+2231
to
+2234
| if (material.hasTexture()) | ||
| finalMaterial->textureMatrix = material.textureMatrix(); | ||
|
|
Contributor
There was a problem hiding this comment.
braces please, as per Meta C++ style guide :)
Contributor
Author
There was a problem hiding this comment.
Clang Tidy was not bullying me about this, so I thought I'm fine here. Always pushing the limits!
mosra
force-pushed
the
flat-texturetransform
branch
from
576d0fa to
198fe92
Compare
jturner65
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes texture transformation with flat materials. Was done for Phong but not for flat.
Once we port away from these custom structures and use Magnum's
MaterialDataeverywhere, this kind of bugs will become much less likely.How Has This Been Tested
Trust Me ™️
Types of changes