Skip to content

Update Corrade and Magnum with prefixed CMake options#1797

Merged
mosra merged 1 commit intomainfrom
update-magnum13
Jun 30, 2022
Merged

Update Corrade and Magnum with prefixed CMake options#1797
mosra merged 1 commit intomainfrom
update-magnum13

Conversation

@mosra
Copy link
Copy Markdown
Contributor

@mosra mosra commented Jun 29, 2022

Motivation and Context

Just a regular batch of (few thousand lines worth of) under-the-hood updates, plus a long-overdue renaming of CMake options to avoid clashes with other projects. Other potentially interesting changes:

  • New plugin for resizing images, useful for reducing texture memory footprint or mip level generation
  • New BitArray and BitArrayView containers, which are getting heavily used for data processing and scene management in the batch renderer.
  • Making distinction between 3D, 2D array and cubemap images for ASTC, DDS, KTX and EXR file formats, which is especially important when dealing with mip levels (they shrink along Z for 3D images, but not for 2D arrays and cubemaps). The lack of such distinction caused considerable friction in data processing for the batch renderer, fortunately no more!

How Has This Been Tested

My CIs pass.

⚠️ To get rid of the old unprefixed CMake options and avoid unexpected clashes in the future you may want to either recreate your build directories, or delete all Corrade- and Magnum-related WITH_*, BUILD_* and TARGET_* options from your CMake cache (ccmake . in the build dir and pressing D on each such entry is a convenient way to do this).

Types of changes

  • Docs change / refactoring / dependency upgrade

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 29, 2022
@mosra mosra force-pushed the update-magnum13 branch from 386dd8e to ed4eaa0 Compare June 29, 2022 19:18
@dhruvbatra
Copy link
Copy Markdown
Contributor

Always happy to see "a few thousand lines worth of under-the-hood updates" that make everyone's life easier :-).

Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosra mosra merged commit 127d26b into main Jun 30, 2022
@mosra mosra deleted the update-magnum13 branch June 30, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants