Update to Magnum with initial support for glTF export and CPU feature dispatch#1834
Merged
Update to Magnum with initial support for glTF export and CPU feature dispatch#1834
Conversation
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Aug 18, 2022
Contributor
aclegg3
left a comment
aclegg3
left a comment
There was a problem hiding this comment.
Thanks, merge when tests pass. 👍
Skylion007
approved these changes
Aug 18, 2022
Oldest version supported by Magnum is now 1.77, from July 2020.
It's there, but it's not with all features the test needs yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Just a regular boring dependency update ... with 20k+ lines of changes.
Interfaces for generic scene export, including meshes, images, scene hierarchy, materials, lights etc. Not hooked up into the command-line tools yet so things like
magnum-sceneconverter gripper_link.dae gripper_link.gltfaren't possible at the moment. But it's getting closer!Initial implementation of a glTF export plugin, which is a prerequisite for the whole preprocessing pipeline in the batch renderer. Currently just (multi-)mesh export. Material, image and scene hierarchy export is in a branch and undergoing a final cleanup.
Compile-time and runtime detection of CPU features (such as AVX or ARM NEON) and dispatch. To be used to select among optimized code paths for batch transformation processing, broadphase visibility culling and other hot code paths in the batch renderer. Earlier benchmarks I did showed a possibility of getting a 2x to 9x speedup in transformation processing by using AVX intrinsics, depending on the compiler.
All other changes and fixes that were too small and insignificant in comparison.
Updates to the batch renderer are depending on these, I'll submit them separately -- wanted to submit the heavy but uncontroversial stuff first to iron out potential build issues.
How Has This Been Tested
My CIs are passing. I'm hopeful it'll eventually be the case here as well :]
Types of changes