Skip to content

Add Franka download#1837

Merged
aclegg3 merged 2 commits intofacebookresearch:mainfrom
laikhtewari:laikh/franka_download
Aug 26, 2022
Merged

Add Franka download#1837
aclegg3 merged 2 commits intofacebookresearch:mainfrom
laikhtewari:laikh/franka_download

Conversation

@laikhtewari
Copy link
Copy Markdown
Contributor

@laikhtewari laikhtewari commented Aug 25, 2022

Motivation and Context

Given new examples using the franka robot in habitat lab, the download utility was updated to include the source for the franka panda URDF model

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 25, 2022
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@laikhtewari laikhtewari marked this pull request as ready for review August 25, 2022 22:04
@aclegg3 aclegg3 merged commit 113c3f1 into facebookresearch:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants