Skip to content

[CI] - fix nightly conda preserve_egg_dir#1844

Merged
aclegg3 merged 2 commits intomainfrom
test-nightly-conda-preserve_egg_dir
Aug 31, 2022
Merged

[CI] - fix nightly conda preserve_egg_dir#1844
aclegg3 merged 2 commits intomainfrom
test-nightly-conda-preserve_egg_dir

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Aug 29, 2022

Motivation and Context

Nightly conda failing due to conflicting files during merge. Implement suggested change setting preserve_egg_dir = True seems to fix it.

How Has This Been Tested

Built and uploaded nightly CI from this PR branch.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from Skylion007 August 29, 2022 22:54
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2022
@aclegg3 aclegg3 requested a review from mathfac August 30, 2022 16:13
Copy link
Copy Markdown
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing this.

@aclegg3 aclegg3 merged commit adea318 into main Aug 31, 2022
@aclegg3 aclegg3 deleted the test-nightly-conda-preserve_egg_dir branch August 31, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants