Skip to content

Add rolling and spinning friction coefficient parameters #1845

Merged
aclegg3 merged 7 commits intomainfrom
rolling-spinning-friction
Aug 30, 2022
Merged

Add rolling and spinning friction coefficient parameters #1845
aclegg3 merged 7 commits intomainfrom
rolling-spinning-friction

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Aug 30, 2022

Motivation and Context

This PR exposes rolling and spinning friction coefficients for objects to the API and configuration system.

How Has This Been Tested

CI tests include get/set through API and configuration system. Locally tested with viewer for correct physics behavior.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 30, 2022
Comment thread src/esp/metadata/attributes/ObjectAttributes.cpp
@aclegg3 aclegg3 merged commit bdd2fdd into main Aug 30, 2022
@aclegg3 aclegg3 deleted the rolling-spinning-friction branch August 31, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants